[node-patches] Change in ovirt-node[ovirt-3.6]: Avoiding displaying vdsmdummy network

fabiand at redhat.com fabiand at redhat.com
Mon Nov 23 17:13:17 UTC 2015


Hello Anatoly Litovsky,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/49025

to review the following change.

Change subject: Avoiding displaying vdsmdummy network
......................................................................

Avoiding displaying vdsmdummy network

or any other network starting with ; for this matter

Change-Id: Id378a054241fa9d4559b2ef6376af7f96bd68475
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1275226
Signed-off-by: Tolik Litovsky <tlitovsk at redhat.com>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/25/49025/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index bab2212..0410977 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -40,6 +40,7 @@
 
 
 class NicTable(ui.Table):
+
     def __init__(self, path, height=3, multi=False, filter_configured=False):
         header = self.__build_header(has_managed_ifnames(),
                                      system.has_systemd(), multi)
@@ -90,6 +91,8 @@
         nics = model.nics(filter_slaveless=True,
                           filter_configured=filter_configured)
         for name, nic in sorted(nics.items()):
+            if nic.ifname.startswith(";"):
+                continue
             if first_nic is None:
                 first_nic = name
             if has_managed_ifnames():
@@ -108,6 +111,7 @@
 
 
 class Plugin(plugins.NodePlugin):
+
     """This is the network page
     """
     _model_extra = {"bond.slaves.selected": []}
@@ -647,6 +651,7 @@
 
 
 class CreateBondDialog(ui.Dialog):
+
     def __init__(self, path):
         widgets = [ui.Entry("bond.name", _("Name:")),
                    ui.Divider("bond.divider[0]"),


-- 
To view, visit https://gerrit.ovirt.org/49025
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id378a054241fa9d4559b2ef6376af7f96bd68475
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>



More information about the node-patches mailing list