[node-patches] Change in ovirt-node[ovirt-3.6]: Prevent adding iptable rule on every run.

[fabiand at redhat.com]

Hello Anatoly Litovsky,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/49027

to review the following change.

Change subject: Prevent adding iptable rule on every run.
......................................................................

Prevent adding iptable rule on every run.

if iptables list is empty a rule will be added to /etc/sysconfig/iptables
We need this rule to be added only once .
Therefor we will load the table before checking
if we need to add the rule.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1221999
Change-Id: Ibe3e80834b9fe817b395793d1a2d02db0c206c4f
Signed-off-by: Tolik Litovsky <tlitovsk at redhat.com>
---
M src/ovirt/node/utils/firewall.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/27/49027/1

diff --git a/src/ovirt/node/utils/firewall.py b/src/ovirt/node/utils/firewall.py
index 260c635..f61ae61 100644
--- a/src/ovirt/node/utils/firewall.py
+++ b/src/ovirt/node/utils/firewall.py
@@ -92,10 +92,10 @@
 
         fs.Config().persist(rules)
 
+    # We need to load the rules before, to prevent overwriting them
+    # when they weren't loaded.
+    load_rules()
     if not is_open():
-        # We need to load the rules before, to prevent overwriting them
-        # when they weren't loaded.
-        load_rules()
         open_port()
         save_rules()
 


-- 
To view, visit https://gerrit.ovirt.org/49027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe3e80834b9fe817b395793d1a2d02db0c206c4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>