[node-patches] Change in ovirt-node[ovirt-3.5]: Move hooks to their own service

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Move hooks to their own service
......................................................................


Patch Set 8:

(1 comment)

One last thing...

https://gerrit.ovirt.org/#/c/47686/8/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1620: 
Line 1621: # Don't actually execute the case statement below if this is sourced as a
Line 1622: # utility script
Line 1623: [[ $BASH_SOURCE != $0 ]] && exit 0
Line 1624: 
Please remove this -- it's no longer necessary (since ovirt-node-hooks is no longer sourcing this to get $OVIRT_LOG and log()), and some of the init.d scripts directly source ovirt-init-functions then run, so this will cause those init scripts to immediately exit.
Line 1625: #
Line 1626: # If called with a param from .service file:
Line 1627: #
Line 1628: case "$@" in


-- 
To view, visit https://gerrit.ovirt.org/47686
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6e4533628fc217c8e6b0d9028b51f38895f4d2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes