[node-patches] Change in ovirt-node[master]: Clean up fstab entries for NFS when wiping the config

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Clean up fstab entries for NFS when wiping the config
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/46026/1/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1113:                 vals = aug.get_many(paths, basepath=prefix)
Line 1114:                 [aug.remove(v) for v in vals.keys() if vals[v] is not None]
Line 1115:                 aug.save()
Line 1116: 
Line 1117:                 fstab_entry = None
This logic will only remove one kdump entry, is that intended?
Line 1118:                 for entry in aug.match("/files/etc/fstab/*"):
Line 1119:                     if aug.get(entry + "/file") == "/var/run/kdump-nfs":
Line 1120:                         fstab_entry = entry
Line 1121:                         break


-- 
To view, visit https://gerrit.ovirt.org/46026
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35aae22d684783fb52597e62d9d197af852f036b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes