[node-patches] Change in ovirt-node[master]: Persist all of /var/lib/net-snmp instead of just snmpd.conf

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Persist all of /var/lib/net-snmp instead of just snmpd.conf
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/46533/1/src/ovirt/node/setup/snmp/snmp_model.py
File src/ovirt/node/setup/snmp/snmp_model.py:

Line 55:                             "SHA", "-x", "AES", "root"])
Line 56:         system.service("snmpd", "start")
Line 57: 
Line 58:         configs = ["/etc/snmp/snmpd.conf", snmp_conf]
Line 59:         [fs.Config().persist(c) for c in configs if not fs.Config().exists(c)]
The issue I see here is backwards compatible.

How does this work if the conf file was persisted previously.

We can workaround it, or it's changed on the snmp side.
Line 60: 
Line 61:     firewall.open_port(port="161", proto="udp")
Line 62: 
Line 63: 


-- 
To view, visit https://gerrit.ovirt.org/46533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef49615cca8eae9107d3ea409db30f71c2815ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes