[node-patches] Change in ovirt-node[master]: syntax: Fix pep8/pyflakes warnings and cleanup the code

fabiand at redhat.com fabiand at redhat.com
Wed Feb 10 14:49:38 UTC 2016


Fabian Deutsch has posted comments on this change.

Change subject: syntax: Fix pep8/pyflakes warnings and cleanup the code
......................................................................


Patch Set 10: Code-Review-2

Thanks a lot for this code contribution!

But I'm sad to say that I'm strongly tending to not merge this patch.

We tried to fixup the codebase in the past (just doing pep8/pyflakes improvements) and it lead to regressions, that is why this code (file) is currently not checked - you'll note that everything under src/ovirt/node/ is getting checked.

-- 
To view, visit https://gerrit.ovirt.org/52678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c446035431ed8748e50a9f2d130d139ccac155c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No



More information about the node-patches mailing list