[node-patches] Change in ovirt-node[master]: Sometimes BridgedNIC gets called with a bridge. Be smarter

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Sometimes BridgedNIC gets called with a bridge. Be smarter
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51560/1/src/ovirt/node/utils/network.py
File src/ovirt/node/utils/network.py:

Line 592:             if vlanid:
Line 593:                 self.logger.debug(" Has tag")
Line 594:                 nic = TaggedNIC(nic, vlanid)
Line 595: 
Line 596:             if layout == "bridged" and not nic.typ == "bridge":
this line might be all we need.
Line 597:                 self.logger.debug(" Is bridged")
Line 598:                 nic = BridgedNIC(nic)
Line 599: 
Line 600:         if nic.typ == "bridge":


-- 
To view, visit https://gerrit.ovirt.org/51560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e99a015ff5904bfccd4c0d1655d5489776a28dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes