[node-patches] Change in ovirt-node[master]: Sometimes BridgedNIC gets called with a bridge. Be smarter

rbarry at redhat.com rbarry at redhat.com
Mon Jan 11 19:18:16 UTC 2016


Ryan Barry has posted comments on this change.

Change subject: Sometimes BridgedNIC gets called with a bridge. Be smarter
......................................................................


Patch Set 4:

I think that's probably ok, Douglas.

This is a patch for the old codebase, and while showing "managed" would be ideal (or some other status, since it's not actually managed by the engine), I'd rather avoid putting a lot of work into this and significantly changing other parts of the networking codebase.

This is to resolve the bug and show the correct ifname. If QE would like bridge slaves to show another status, I'd rather that they file an RFE which can be evaluated separately from this bug.

-- 
To view, visit https://gerrit.ovirt.org/51560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e99a015ff5904bfccd4c0d1655d5489776a28dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No



More information about the node-patches mailing list