[node-patches] Change in ovirt-node[master]: Unset BOOTIF if it's already set (TUI upgrades)

fabiand at redhat.com fabiand at redhat.com
Tue Jan 19 21:03:24 UTC 2016


Fabian Deutsch has posted comments on this change.

Change subject: Unset BOOTIF if it's already set (TUI upgrades)
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/52450/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 929:             echo "set /files$OVIRT_DEFAULTS/OVIRT_$PARAM '\"$value\"'" >> $tmpaug
Line 930:         fi
Line 931:     done
Line 932:     # block accidental bootif changes on upgrades
Line 933:     grep -q BOOTIF /etc/default/ovirt
grep -sq ? to prevent an error if /etc/default/ovirt does not exist? Can this happen?
Line 934:     bootif_set=$?
Line 935:     if [[ "$upgrade" == "1" || $bootif_set -eq 0 ]]; then
Line 936:         sed -i '/OVIRT_BOOTIF/d' $tmpaug
Line 937:     fi


-- 
To view, visit https://gerrit.ovirt.org/52450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d64efb10d4f3bbf7d5a482c76675ed56c4eaf10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes



More information about the node-patches mailing list