[node-patches] Change in ovirt-node[master]: Unset BOOTIF if it's already set (TUI upgrades)

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Unset BOOTIF if it's already set (TUI upgrades)
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/52450/3/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 933:     done
Line 934:     # block accidental bootif changes on upgrades
Line 935:     grep -sq BOOTIF /etc/default/ovirt
Line 936:     bootif_set=$?
Line 937:     if [[ "$upgrade" == "1" || $bootif_set -eq 0 ]]; then
Does this logic not also remove BOOTIF from defaults during the normal boot?

And if BOOTIF is removed during normal boot, does this not have an impact on the TUI?
Line 938:         sed -i '/OVIRT_BOOTIF/d' $tmpaug
Line 939:     fi
Line 940:     augtool $tmpaug
Line 941:     . $OVIRT_DEFAULTS


-- 
To view, visit https://gerrit.ovirt.org/52450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d64efb10d4f3bbf7d5a482c76675ed56c4eaf10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes