[node-patches] Change in ovirt-node[master]: Unset BOOTIF if it's already set (TUI upgrades)

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Unset BOOTIF if it's already set (TUI upgrades)
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/52450/3/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 933:     done
Line 934:     # block accidental bootif changes on upgrades
Line 935:     grep -sq BOOTIF /etc/default/ovirt
Line 936:     bootif_set=$?
Line 937:     if [[ "$upgrade" == "1" || $bootif_set -eq 0 ]]; then
> Does this logic not also remove BOOTIF from defaults during the normal boot
Yes and no. 

In the case of a normal PXE install, /etc/default/ovirt will not have any values set yet, so the grep will fail.

For stateless PXE boots, this would prevent BOOTIF from being set with the updated value, but I don't think stateless is a supported configuration.

For normal boots, this simply prevents an extraneous BOOTIF on the cmdline from overwriting what's already present in /etc/default/ovirt, but since stateless is not supported, that's not something we'd expect anyway.
Line 938:         sed -i '/OVIRT_BOOTIF/d' $tmpaug
Line 939:     fi
Line 940:     augtool $tmpaug
Line 941:     . $OVIRT_DEFAULTS


-- 
To view, visit https://gerrit.ovirt.org/52450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d64efb10d4f3bbf7d5a482c76675ed56c4eaf10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes