[node-patches] Change in ovirt-node[master]: fs/__init__.py: check if it's a file before chksum

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: fs/__init__.py: check if it's a file before chksum
......................................................................


Patch Set 3: Code-Review-2

(1 comment)

https://gerrit.ovirt.org/#/c/56508/3/src/ovirt/node/utils/fs/__init__.py
File src/ovirt/node/utils/fs/__init__.py:

Line 686:         persisted_path = self._config_path(filename)
Line 687: 
Line 688:         if not os.path.exists(persisted_path) or \
Line 689:                 not os.path.exists(filename) or \
Line 690:                 not os.path.isfile(filename):
But filename can be a dir.

We allow to persist dirs.
Line 691:             return False
Line 692: 
Line 693:         current_checksum = self.cksum(filename)
Line 694:         stored_checksum = self.cksum(persisted_path)


-- 
To view, visit https://gerrit.ovirt.org/56508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a50dca7521336a9feafbc6c03fa38e1a57a6ba9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes