[ovirt-users] engine-iso-uploader unexpected behaviour (steve a)

[Yedidyah Bar David]

----- Original Message -----
> From: "Steve Atkinson" <satkinson at telvue.com>
> To: "Yedidyah Bar David" <didi at redhat.com>
> Cc: users at ovirt.org
> Sent: Wednesday, December 31, 2014 11:18:39 PM
> Subject: Re: [ovirt-users] engine-iso-uploader unexpected behaviour (steve a)
> 
> in our case our nas doesn't support scp but that no fault of the the
> manager.
> 
> I was mentioning more specifically that the --nfs-server method seemed to
> throw an error on an undefined attribute 'domaintype' that is not something
> that can be supplied in the config file or passed as an argument. the out
> put from the the debug is further up in my first email.

Sorry.

You wrote:
> Alternatively, using engine-iso-uploader --nfs-server=[path] upload [iso]
> --verbose returns the following error:
>
> ERROR: local variable 'domain_type' referenced before assignment
> INFO: Use the -h option to see usage.
> DEBUG: Configuration:
> DEBUG: command: upload
> DEBUG: Traceback (most recent call last):
> DEBUG: File "/usr/bin/engine-iso-uploader", line 1440, in <module>
> DEBUG: isoup = ISOUploader(conf)
> DEBUG: File "/usr/bin/engine-iso-uploader", line 455, in __init__
> DEBUG: self.upload_to_storage_domain()
> DEBUG: File "/usr/bin/engine-iso-uploader", line 1089, in
> upload_to_storage_domain
> DEBUG: elif domain_type in ('localfs', ):
> DEBUG: UnboundLocalError: local variable 'domain_type' referenced before
> assignment

That's indeed a bug. Now pushed a one-line fix [1]. If you can, please
try and it report. Thanks!

[1] http://gerrit.ovirt.org/36499

Feel free to also open a bz for inclusion in some version earlier than 3.6
(our current master branch).

> 
> you are right though. probably not worth it since the best solution would
> be a gui implementation.

That's not what I meant - a gui is obviously more comfortable for casual
use, but for batch/scripting etc you want a command line tool. But
hopefully our implementation for the gui uploader will be first in the
rest api, then in the gui. The rest api will be useful also for scripting -
either directly or by reimplementing the current tool with it.

Thanks and best regards,
-- 
Didi