[ovirt-users] Proposing fix for EL6 m2crypto memory leak

[Daniel Helgenberger]

On 28.10.2014 11:55, Sandro Bonazzola wrote:
> Il 28/10/2014 11:07, Daniel Helgenberger ha scritto:
>> Hello Sandro,
>>
>> I just updated BZ [1] that m2crypto-0.21.1 from FC20 fixes the severe
>> mem leak issue in VDSM for me on EL6 with Engine 3.4 and 3.5.
>>
>> As I have seen no side effects, I propose adding a newer m2crypto to the
>> ovirt EL6 repos; with fixes the issue immediately (well, you need to
>> restart vdsmd).
>>
>> Should I open an RFE or will this mail to the list suffice? For
>> convenience, I added the rpm I am using as well as the SRPM I used to
>> compile this version [2].
>
> Let me see if I've understood.
> Fedora 20 already have m2crypto-0.21.1-13.fc20
> Fedora 19 has m2crypto-0.21.1-11
>
> Looking at the RPM changelog [1], 0.21.1-11 on F19 and your 0.21.1-12 on F20 are just mass rebuild so no update needed on Fedora.
I also think that EL7's version might be fine, too. I just used the 
version from fc20 because it was a known working one confirmed by 
Markus, see BZ (I confess I did not read through the changelogs but was 
only interested in solving the issue :)

>
> CentOS 7 has m2crypto-0.21.1-15 and don't need an update.
>
> CentOS 6.6 has m2crypto-0.20.2-9 (yes, centos 6.6 is out http://isoredirect.centos.org/centos/6.6/)
> which looks the same on 6.5.
> Are you really sure that the issue is on m2crypto side and not on vdsm side?
Not quite. The issue is fixed however. It can still be a bug in VDSM 
with some special call or something. But I clearly lack knowledge here.

My reasoning is, however, finding the root cause might be a time 
consuming process and the outcome in the end only be of academical value 
since the issue is not there with newer versions of m2crypto.

> If so, a bug against m2crytpo should be opened and quickly fixed on RHEL/CentOS.
Thats what I am asking in the BZ. I am happy to open the issue in RHEL 
(CentOS is downstream...) but I have no subscription and cannot confirm 
the version RHEL is using. Also I need someone who can answer whatever 
this is an issue of m2crypto or VDSM (see above).

>
> I don't think that just rebuilding m2crypto from F20 is a long term solution.
Me neither. But it is a short term solution until the issue is fixed or 
El6 obsoleted (well, this might be quite soon for a protect like oVirt?)
Also, the new m2cypto version might be requirement of the VDSM rpm in 
the future; I think there are few people witch run VDSM apart from being 
an oVirt / RHEV host. This way the impact and possible side effects are 
minimized (if there are any).

>
> Dan?
>
> [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=485699
>
>
>
>>
>>
>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1147148
>> [2]
>> ftp://rpmfind.net/linux/fedora-secondary/development/rawhide/source/SRPMS/m/m2crypto-0.21.1-12.fc20.src.rpm
>>
>
>

-- 
Daniel Helgenberger
m box bewegtbild GmbH

P: +49/30/2408781-22
F: +49/30/2408781-10

ACKERSTR. 19
D-10115 BERLIN


www.m-box.de  www.monkeymen.tv

Geschäftsführer: Martin Retschitzegger / Michaela Göllner
Handeslregister: Amtsgericht Charlottenburg / HRB 112767