[Engine-devel] UI Plugins configuration

[Frantz, Chris]

Vojtech,

Here is my patch against WIP-UI-Plugins-PoC-revision-4.  I’ve also included 2 dummy plugins in sample.tar.gz.

--Chris


From: engine-devel-bounces at ovirt.org [mailto:engine-devel-bounces at ovirt.org] On Behalf Of Frantz, Chris
Sent: Thursday, August 30, 2012 1:06 PM
To: Vojtech Szocs
Cc: engine-devel
Subject: Re: [Engine-devel] UI Plugins configuration

Vojtech,

I agree with your formalized names:

Plugin Descriptor is the JSON file containing plugin meta-data. The plugin descriptor may also contain the default configuration data.   It is located in $DATADIR/ui-plugins.

Plugin Configuration is the JSON file containing optional plugin configuration info.  It is located in $CONFIGDIR/ui-plugins (unless the Plugin Descriptor contains an absolute path).

Plugin Definition is the JavaScript object used by WebAdmin.  In the current implementation, the Plugin Definition contains both the Plugin Descriptor and the Plugin Configuraion.

Plugin Source Page is the HTML page used to invoke the plugin code and shall be referenced by the plugin descriptor’s “url” attribute.

I’ve implemented the config merging you’ve suggested:  the structure in configFile gets merged with the structure of “config”, with the data in configFile winning in the case of duplicate key names.

BTW, the patch is against ovirt-engine + 0001-WIP-UI-Plugins-PoC-revision-2.

Let me know what you think,
--Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20120830/706f0e22/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sample.tar.gz
Type: application/x-gzip
Size: 1250 bytes
Desc: sample.tar.gz
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20120830/706f0e22/attachment-0002.gz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UI-Plugins-Config-4.patch
Type: application/octet-stream
Size: 17270 bytes
Desc: UI-Plugins-Config-4.patch
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20120830/706f0e22/attachment-0002.obj>