[Engine-devel] maven settings.xml in building ovirt engine wiki

[Alissa Bonas]

Hi,

In this wiki http://wiki.ovirt.org/wiki/Building_oVirt_engine

The suggested maven settings.xml contains hardcoded paths to jboss_home and java_home.
IMHO it's better to use environment variables to take the above settings from there, instead of managing those settings twice in 2 different places.

The current settings look like this (note that java path is incorrect anyway, including /bin/java)

 <jbossHome>/usr/share/jboss-as</jbossHome>
 <JAVA_HOME>/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.0.x86_64/bin/java</JAVA_HOME>

How about changing settings.xml to something like:

  <jbossHome>${env.JBOSS_HOME}</jbossHome>
  <JAVA_HOME>${env.JAVA_HOME}</JAVA_HOME>


Does anyone see a problem with the suggested approach?

Thanks

Alissa