[ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master

[Tal Nisan]

Acked, let me know if you need me to merge

On Tue, Dec 15, 2015 at 12:36 PM, Tomas Jelinek <tjelinek at redhat.com> wrote:

>
>
> ----- Original Message -----
> > From: "Tal Nisan" <tnisan at redhat.com>
> > To: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Einav Cohen" <
> ecohen at redhat.com>
> > Cc: "devel" <devel at ovirt.org>
> > Sent: Tuesday, December 15, 2015 11:29:17 AM
> > Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing
> on    master
> >
> > Einav, it seems like an old issue we had when the default message
> contains
> > the necessary placeholders but since no translations patch was released
> yet
> > we don't have the placeholders in the translated messages, did we decide
> on
> > a workaround back then?
>
> This particular issue is only happening when you change a message which
> has already been in localized property files
> in a way that you change the num of parameters of it.
>
> This fixes it: https://gerrit.ovirt.org/#/c/50506/
> Tested with 2 locales and seems to be working - Tal, adding you as a
> reviewer since you are already in the thread ;)
>
> >
> > On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola < sbonazzo at redhat.com
> >
> > wrote:
> >
> >
> >
> > 05:22:42 [INFO]                   [ERROR] Required argument 3 not
> present:
> > {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO]    [ERROR]
> Errors in
> > 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO]
> > [ERROR] Line 38: Failed to resolve
> > 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding
> >
> > See
> >
> http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/682/console
> >
> > Please fix ASAP
> >
> >
> > --
> > Sandro Bonazzola
> > Better technology. Faster innovation. Powered by community collaboration.
> > See how it works at redhat.com
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> >
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20151215/91994d6e/attachment-0001.html>