[ovirt-devel] [vdsm] libvirtconnection test failures on my box

[Francesco Romani]

Hi all,


since yesterday, running 'make check' on my F26 box I get those errors:


======================================================================
ERROR: libvirtMock will raise an error when nodeDeviceLookupByName is
called.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File
"/home/fromani/Projects/upstream/vdsm/tests/common/libvirtconnection_test.py",
line 150, in testCallFailedConnectionDown
    connection = libvirtconnection.get(killOnFailure=True)
TypeError: __init__() got an unexpected keyword argument 'killOnFailure'
-------------------- >> begin captured logging << --------------------
2017-12-12 09:57:05,801 DEBUG (libvirt/events) [root] START thread
<Thread(libvirt/events, started daemon 140602075010816)> (func=<bound
method _EventLoop.__run of <vdsm.common.libvirtconnection._EventLoop
instance at 0x7fe081993128>>, args=(), kwargs={}) (concurrent:189)
2017-12-12 09:57:05,802 DEBUG (libvirt/events) [root] FINISH thread
<Thread(libvirt/events, started daemon 140602075010816)> (concurrent:192)
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: libvirtMock will raise an error when nodeDeviceLookupByName is
called.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File
"/home/fromani/Projects/upstream/vdsm/tests/common/libvirtconnection_test.py",
line 132, in testCallFailedConnectionUp
    connection = libvirtconnection.get(killOnFailure=True)
TypeError: __init__() got an unexpected keyword argument 'killOnFailure'
-------------------- >> begin captured logging << --------------------
2017-12-12 09:57:05,803 DEBUG (libvirt/events) [root] START thread
<Thread(libvirt/events, started daemon 140602075010816)> (func=<bound
method _EventLoop.__run of <vdsm.common.libvirtconnection._EventLoop
instance at 0x7fe081993128>>, args=(), kwargs={}) (concurrent:189)
2017-12-12 09:57:05,803 DEBUG (libvirt/events) [root] FINISH thread
<Thread(libvirt/events, started daemon 140602075010816)> (concurrent:192)
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: Positive test - libvirtMock does not raise any errors
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File "/home/fromani/Projects/upstream/vdsm/tests/monkeypatch.py", line
134, in wrapper
    return f(*args, **kw)
  File
"/home/fromani/Projects/upstream/vdsm/tests/common/libvirtconnection_test.py",
line 118, in testCallSucceeded
    connection.nodeDeviceLookupByName()
TypeError: nodeDeviceLookupByName() takes exactly 2 arguments (1 given)
-------------------- >> begin captured logging << --------------------
2017-12-12 09:57:05,804 DEBUG (libvirt/events) [root] START thread
<Thread(libvirt/events, started daemon 140602075010816)> (func=<bound
method _EventLoop.__run of <vdsm.common.libvirtconnection._EventLoop
instance at 0x7fe081993128>>, args=(), kwargs={}) (concurrent:189)
2017-12-12 09:57:05,804 DEBUG (libvirt/events) [root] FINISH thread
<Thread(libvirt/events, started daemon 140602075010816)> (concurrent:192)
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------


Smells like incorrect monkeypatching leaking out of test module.

The last one is easy, seems just incorrect call, I have a fix pending.
However, why is it starting to fail just now?

It seems to run fine on CI, which is interesting.


Any help is welcome


Bests,


-- 
Francesco Romani
Senior SW Eng., Virtualization R&D
Red Hat
IRC: fromani github: @fromanirh