[ovirt-devel] [ OST Failure Report ] [ Failed Build ] [ oVirt engine master ]

[Greg Sheremeta]

Sorry for the trouble. I put clearly in the commit message:

This patch deletes 'frontend/webadmin/modules/userportal-gwtp' and won't
pass CI on its own. Patch 3/3 will pass.

I think it's reasonable that not every single patch will pass CI. Sometimes
patches are so large that they need to be split. And usually we can split
things such that each patch compiles, but in this case it didn't make sense
to me.

On Wed, Jul 19, 2017 at 6:58 AM, Barak Korren <bkorren at redhat.com> wrote:

>
>
> On 19 July 2017 at 13:49, Oved Ourfali <oourfali at redhat.com> wrote:
>
>> If that's the case, we should make sure in the future that patches are
>> self contained, even if the plan is to push them together.
>>
>>
> That is axiomatically true if you want any useful CI...
>
> Maybe some tests should be added to check-patch to ascertain that...
>
> --
> Barak Korren
> RHV DevOps team , RHCE, RHCi
> Red Hat EMEA
> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Greg Sheremeta, MBA
Sr. Software Engineer
Red Hat, Inc.
gshereme at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170719/1e6e1ffb/attachment.html>