[ovirt-devel] patch granularity, extracting patches

Greg Sheremeta gshereme at redhat.com
Thu Jun 29 16:16:59 UTC 2017


Do we have or follow a standard on patch granularity? When I started, I
picked up on the culture that we do small, logical commits -- as much as
possible, each commit should be focused on a specific purpose. I've
perceived some reviewers prefer to have all orthogonal changes (fix a
random spelling error, remove a duplicate semicolon) extracted to other
patches for clarity. Others don't seem to mind. I feel like I always want
to ask, but I feel bad because it's a hassle.

Also, when you are asked to extract something, do you have a trick to make
it as easy as possible?

Best wishes,
Greg

-- 
Greg Sheremeta, MBA
Sr. Software Engineer
Red Hat, Inc.
gshereme at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170629/f68fe0e1/attachment.html>


More information about the Devel mailing list