Change in ovirt-engine[master]: core: Remove GetEventNotificationMethodByType

lhornyak at redhat.com lhornyak at redhat.com
Fri Apr 12 08:29:50 UTC 2013


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Remove GetEventNotificationMethodByType
......................................................................


core: Remove GetEventNotificationMethodByType

GetEventNotificationMethodByTypeQuery is not used anywhere in
the code, and hence should be removed.

This patch removes the following:
1. The GetEventNotificationMethodByTypeQuery class.
2. The GetEventNotificationMethodByType constant representing
   it in VdcQueryType.
3. The GetEventNotificationMethodByTypeParameters class only used by
   the aforementioned query.
3. The getAllEventNotificationMethodByTppe() method in EvetDAO, its
   implementation, test and underlying stored procedure, as this
   method was only used by the aforementioned query.

Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/dbscripts/event_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodByTypeQuery.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEventNotificationMethodByTypeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
7 files changed, 0 insertions(+), 80 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13602
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list