Change in ovirt-engine[master]: core: reduce compensation scope from hibernate command

ofrenkel at redhat.com ofrenkel at redhat.com
Mon May 20 06:36:33 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: reduce compensation scope from hibernate command
......................................................................


core: reduce compensation scope from hibernate command

This patch reduce the scope in which the compensation that is defined
to switch the VM status back to UP is set in the execute stage of the
hibernate vm command.

The compensation context is cleared when the first task is created (in
transaction) - there's no need to keep the compensation anymore since we
don't want the status of the VM to switch to UP while tasks that were
created as part of the hibernate command exist.

Note: this is only part of the solution for the bug mentioned below.

Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910
Bug-Url: https://bugzilla.redhat.com/949281
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
2 files changed, 59 insertions(+), 32 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list