Change in ovirt-engine[master]: core: Unify both @Before methods in HotPlugDiskToVmCommand

tnisan at redhat.com tnisan at redhat.com
Wed Apr 20 17:14:58 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Unify both @Before methods in HotPlugDiskToVmCommand
......................................................................


core: Unify both @Before methods in HotPlugDiskToVmCommand

Unify both @Before methods to make the code more readable, having one
method at the top of the class can result in missing the second one which
is in the middle of the class.
By JUnit spec the order multiple @Before methods are invoked is not
guaranteed so it doesn't matter which content comes first

Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 15 insertions(+), 18 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list