Change in otopi[master]: minidnf: drop fill_sack on clean

didi at redhat.com didi at redhat.com
Fri Aug 5 12:05:37 UTC 2016


Yedidyah Bar David has submitted this change and it was merged.

Change subject: minidnf: drop fill_sack on clean
......................................................................


minidnf: drop fill_sack on clean

In clean method we called fill_sack right after
expiring metadata. This caused a SIGABRT to be
raised by one of the C libraries used by DNF.

We've not completely understood why this happen but
we can safely drop the call to fill_sack here.
The clear operation is called within a minidnf.transaction
so the sack will be destroyed right after the cleaning.
Next operations are still within another minidnf.transaction so
the sack will be filled again in a fresh new base object.

Change-Id: I05755de3406a811434236e020061bdf3ad1680ff
Bug-Url: https://bugzilla.redhat.com/1361888
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M src/otopi/minidnf.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests
  Rafael Martins: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61975
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05755de3406a811434236e020061bdf3ad1680ff
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list