Change in ovirt-engine[master]: core: cleanup in vm analyzer

ahadas at redhat.com ahadas at redhat.com
Tue Feb 2 12:10:06 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup in vm analyzer
......................................................................


core: cleanup in vm analyzer

1. Extract calls to Destroy to separate methods
2. Replace calls to the depracated ResourceManager#getInstance
3. Extract code related to audit logs to separate methods
4. Use Early return to simplify updateVmRunTimeInfo
5. Rename variable props to changedFields
6. Use Stream API to simplify updateVmNumaNodeRuntimeInfo

Change-Id: Ic6bf23080fd5e94d98c051296fe11f7524ea6c10
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
1 file changed, 90 insertions(+), 79 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6bf23080fd5e94d98c051296fe11f7524ea6c10
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list