Change in ovirt-engine[master]: core: ImportVmCommandStub#initUser()

amureini at redhat.com amureini at redhat.com
Thu Oct 13 20:50:22 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImportVmCommandStub#initUser()
......................................................................


core: ImportVmCommandStub#initUser()

The initUser() method is not needed anywhere in the test, and stubbing
it does nothing but distract the reader from the actual test.

This patch removes its stubbing in order to clean up the code.

Change-Id: Iec1254ad4c525c51edbeee0756299f64d8c0569b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec1254ad4c525c51edbeee0756299f64d8c0569b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list