Change in ovirt-engine[master]: core: Replace VmHandlerRule with injection

tnisan at redhat.com tnisan at redhat.com
Wed Oct 19 11:02:11 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Replace VmHandlerRule with injection
......................................................................


core: Replace VmHandlerRule with injection

The current injection facilities provide a much simpler, safer (as they
don't rely on field name reflection) way to inject dependencies into the
VmHandler.

This patch removes the outdated VmHandlerRule and replaces its usages
with more straight-forward injections.

Change-Id: I795db463f7be8e48e4e51042ba8be10f510f7451
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerRule.java
2 files changed, 2 insertions(+), 79 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65191
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795db463f7be8e48e4e51042ba8be10f510f7451
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list