Change in ovirt-engine[master]: webadmin: Dashboard icon

Code Review gerrit at ovirt.org
Tue Aug 1 19:30:09 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80072 )

Change subject: webadmin: Dashboard icon
......................................................................


webadmin: Dashboard icon

- Due to recent changes, DynamicTab extended SimpleTab which
  caused the TabFactory to never get to DynamicTab as SimpleTab
  comparison happened first. Change the order to have the more
  specific instanceof check (DynamicTab) happen first.

Change-Id: I1697372e1526f07974d754803942423ca3fc7633
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/TabFactory.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Alexander Wels: Verified; Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1697372e1526f07974d754803942423ca3fc7633
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list