Change in ovirt-engine[master]: aaa: welcome page is now protected by login

Code Review gerrit at ovirt.org
Mon Jul 3 13:38:57 UTC 2017


>From Ravi Nori <rnori at redhat.com>:

Ravi Nori has submitted this change and it was merged. ( https://gerrit.ovirt.org/78832 )

Change subject: aaa:  welcome page is now protected by login
......................................................................


aaa:  welcome page is now protected by login

When checking for auth:identity scope
the OAuthAuthorizeServlet should check
scope in the request and not the scope
in the SsoSession as auth:identity scope
is not persisted in the SooSession.

Change-Id: Ifb5ff2906c189fee41b785226110a741a3d838b0
Bug-Url: https://bugzilla.redhat.com/1466070
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
4 files changed, 9 insertions(+), 14 deletions(-)

Approvals:
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb5ff2906c189fee41b785226110a741a3d838b0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list