Change in ovirt-engine[master]: packaging: Extract the value correctly from postgresql.conf

Code Review gerrit at ovirt.org
Thu Mar 23 09:07:48 UTC 2017


>From Roy Golan <rgolan at redhat.com>:

Roy Golan has submitted this change and it was merged.

Change subject: packaging: Extract the value correctly from postgresql.conf
......................................................................


packaging: Extract the value correctly from postgresql.conf

Motivation:
Updating postgres.conf using setup plugin fails to catch floating point changes
The root cause it the regular expression that extracts a key=value and
for comparison

Change:
The regexp is change to take every char till end of line as value.

Result:
Instead of extracting 0 for 0.5 it now extracts correctly.
Floating points and all other values are extracted correctly.

Change-Id: I6db33a9d7bd3e87d537fd03d5032bf73fa844dd7
Bug-Url: https://bugzilla.redhat.com/1388433
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 13 insertions(+), 14 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Gil Shinar: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Verified



-- 
To view, visit https://gerrit.ovirt.org/73942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6db33a9d7bd3e87d537fd03d5032bf73fa844dd7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list