Change in ovirt-engine[master]: engine: Remove spare injection in PowerSavingBalancePolicyUnit

Code Review gerrit at ovirt.org
Thu May 11 12:10:12 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Remove spare injection in PowerSavingBalancePolicyUnit
......................................................................


engine: Remove spare injection in PowerSavingBalancePolicyUnit

The information relevant for logging the event is available when
creating the event. Injection can be avoided in this context.
In addition, despite of using ${Host} in the audit log message as the
host name, the event should contain also the host name and host id so
the event can be associated with the actual host in the system.
The same assumption is applied to the cluster in which the action takes
place.

Change-Id: I350047e97335967593490b1756059862d9447585
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, but someone else must approve
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76535
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I350047e97335967593490b1756059862d9447585
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list