Change in ovirt-engine[master]: engine: CinderBroker is not AuditLogableBase

Code Review gerrit at ovirt.org
Thu May 11 12:10:13 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: CinderBroker is not AuditLogableBase
......................................................................


engine: CinderBroker is not AuditLogableBase

CinderBroker inherits from AuditLogableBase only for the sake of
logging. However, that functionality can be obtained by using the
AuditLogDirector properly, without the need to inherit logging
capabilities.

Bug-Url: http://bugzilla.redhat.com/1448793
Change-Id: Id0c0b1efe0bdd1589c2d4f7bdccd6e5a4061eb65
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CinderBroker.java
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76564
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0c0b1efe0bdd1589c2d4f7bdccd6e5a4061eb65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list