Adding a new flag to a specific gerrit project?

Juan Hernández jhernand at redhat.com
Thu Jun 2 09:11:35 UTC 2016


Thanks David. I am answering your questions below. Derek, Lucy,
Andrew, please review and confirm if you agree.

On 06/02/2016 09:35 AM, David Caro wrote:
> On 06/01 16:54, Juan Hernández wrote:
>> Hello,
>> 
>> As part of the effort to improve the documentation of the REST
>> API the documentation team will help us review the patches for
>> the specification. I was wondering if it is possible to add a new
>> flag, like the CR, CI, and V that we currently have. Would be
>> nice to have a "Documentation" flag (or similar) so that the
>> documentation team can +1 that flag. Is this possible? Can this
>> flag be added to the ovirt-engine-api-model project?
> 
> Yes, it's possible, I'll need more details about it though like: *
> max and min values?

The min should be -1, and the max +1. The associated descriptions
could be the following:

-1: Documentation doesn't look good
 0: Documentation hasn't been reviewed
+1: Documentation looks good

> * Should a +1/+2 be required to submit?

Yes, +1 should be required to submit.

> * Should -1/-2 block submits?

Yes, -1 should block submits.

> 
>> Can we define a group of users that have permissions to set this
>> flag?
> 
> Yep, for that a list of the gerrit usernames will be required. Also
> think if you want to give any other group (like maintainers) the
> ability to set it too, as depending on the policy you select in the
> previous question it might be required to merge.

Yes, the maintainers group should have permission to set this flag.

To start with, the names of the users of that group should be the
following:

  Lucy Bopf <lbopf at redhat.com>
  Andrew Dahms <adahms at redhat.com>

Derek, Lucy, Andrew, any other names to add to this group?

David, please wait for comments from Derek, Lucy and Andrew before
making this changes.

-- 
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.



More information about the Infra mailing list