[Kimchi-devel] [PATCH] Addition of custom mac address field for interfaces v3

Brent Baude bbaude at redhat.com
Wed Oct 1 20:03:58 UTC 2014


I think that is because Aline and Royce wanted me to regex check the
incoming MAC address with JSON.  This is a direct result of that.  I'll
have to see if I can make it be blank which was allowed prior to that.

On Wed, 2014-10-01 at 16:59 -0300, Crístian Viana wrote:
> Oh, and I forgot to add another thing. With this patch, the MAC
> address
> becomes required when the user adds a new NIC. If I don't type an
> address, I get the following error:
> 
> Invalid MAC address format. Expected a 12 character hexadecimal value
> separated by colons(:)
> 
> I think that's a bad thing because most of the times the user doesn't
> care about which MAC address is assigned to their NIC. So IMO if the
> user leaves that field blank, a random MAC should be generated, just
> like before. But if they type something, that must be validated
> indeed.
> 
> I see that there's code dealing exactly with that, but it's not
> working with me.
> 
> On Qua, 2014-10-01 at 10:03 -0500, bbaude at redhat.com wrote: 
> > From: Brent Baude <bbaude at redhat.com>
> > 
> > Fixed json issue and included comments from pvital
> 





More information about the Kimchi-devel mailing list