[Kimchi-devel] [PATCH v2] Support Linux Bridge creation

[Lucio Correia]

On 05-11-2015 11:42, Aline Manera wrote:
>
>
> On 04/11/2015 09:24, Lucio Correia wrote:
>> On 30-10-2015 15:41, Aline Manera wrote:
>>>
>>>
>>> On 30/10/2015 14:29, Ramon Medeiros wrote:
>>>> Create linux-bridge with libvirt API. Kimchi was only creating macvtap
>>>> devices, with has some limitation. For further information, take a look
>>>> at Kimchi wiki discuss:
>>>> https://github.com/kimchi-project/kimchi/wiki/Create-guest-network
>>>>
>>>> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
>>>>
>>>> Changes:
>>>>
>>>> v2:
>>>>
>>>> Remove unused imports and constants
>>>> Fix pep8 issues
>>>>
>>>>
>>>> Testing:
>>>>
>>>> In my case, i create a new bridge over the interface enp0s25 with name
>>>> ramon
>>>>
>>>> curl -u root  -H "Content-Type: application/json" -H "Accept:
>>>> application/json" "http://localhost:8010/plugins/kimchi/networks" -X
>>>> POST -d '{"name": "ramon", "connection":"bridge",
>>>> "interface":"enp0s25", "mode":"linux-bridge"}'
>>>
>>>  From what I remembered from the RFC, we have agreed to do not add a new
>>> parameter "mode" and instead of that use "connection" equal to "macvtap"
>>> for macvtap bridge or "bridge" for Linux bridge.
>>>
>>> Any special reason to do not follow the RFC discussion?
>>>
>>
>> Aline, could you point me to that discussion? I'm out of context here.
>>
>>
>
> This is the mail thread:
> http://lists.ovirt.org/pipermail/kimchi-devel/2015-October/011981.html
>

Thanks! I will fix that as well.

>


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil