[Kimchi-devel] [PATCH 4/5] [WOK] Updating Kimchi plugin with new-ui

[Samuel Henrique De Oliveira Guimaraes]

Hi Lucio,

The buttons.css file was there just in case I need to load old Kimchi styles when I'm editing a page. I just wrapped all classes in it with a .kimchi class because Wok is now using default Bootstrap buttons that coincidently have the same classes names (.btn). In the finished product we won't need this file and probably won't need icon.css either. We definitely won't need grid.css because I've updated grid.js with Bootstrap table markup and customized it according to the new-ui spec.

Some CSS files / widgets can be removed in the final release because Bootstrap already provides CSS classes and JS files for them (which are buttons, drop down buttons, tabs, form fields, modal windows/dialogs and the grid). For now I'm adapting the current JS generated markup with Bootstrap markup but in the future we can use Bootstrap default widgets and discard all the duplicated functionality.

I hadn't the chance to apply this patch yet because I was working on the grid widget and I was planning to move from Kimchi to Wok and rename it once I'm done. I'll take a look.

Thanks,
Samuel 

-----Original Message-----
From: kimchi-devel-bounces at ovirt.org [mailto:kimchi-devel-bounces at ovirt.org] On Behalf Of Lucio Correia
Sent: quinta-feira, 10 de setembro de 2015 17:09
To: kimchi-devel at ovirt.org
Subject: Re: [Kimchi-devel] [PATCH 4/5] [WOK] Updating Kimchi plugin with new-ui

On 09/10/2015 04:38 PM, Aline Manera wrote:
>
>
> On 25/08/2015 17:06, sguimaraes943 at gmail.com wrote:
>> From: samhenri <samuel.guimaraes at eldorado.org.br>
>>
>> Added some new-ui markup to Kimchi. Please note that some pages may 
>> stop working since the new-ui is not finished yet.
>>
>> Signed-off-by: samhenri <samuel.guimaraes at eldorado.org.br>
>> ---
>>   plugins/kimchi/ui/config/tab-ext.xml
>
>>      |   7 +-
>>   plugins/kimchi/ui/css/theme-default/button.css |  72 
>> +++++++--------
>
> This CSS file is applied for all the buttons in the application, right?
> If so it should be into wok instead of kimchi...
>
> All the widgets and style related should be on wok and only reuse in 
> the plugins.
>
> So unless, Kimchi wants to change the default button style this file 
> button.css should not exist on kimchi.
>
> Thinking on that direction the CSS should be changed to add 'wok' as 
> CSS class prefix and moved to wok UI directory.
>
>>   plugins/kimchi/ui/images/logo.ico              | Bin 1214 -> 15086
>> bytes
>
>>   plugins/kimchi/ui/js/src/kimchi.grid.js        |  13 +--
>
> Same I commented above.
> It is related to the grid widget, so should be on wok.
>

Samuel, with recent merges into upstream branch wok, grid.css and button.css are now already in wok.

I've also split button.css into a generic part (in wok) and a small kimchi-specific part for which I created an icon.css in kimchi.


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel at ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel