-----Original Message----- From: Mike Burns [mailto:mburns@redhat.com] Sent: Friday, October 28, 2011 3:13 AM To: Itamar Heim Cc: engine-devel@ovirt.org; infra@ovirt.org; board@ovirt.org Subject: Re: ovirt-engine repo up in gerrit.ovirt.org!
On Thu, 2011-10-27 at 23:51 +0200, Itamar Heim wrote:
Here we go...
- gerrit is up. - ovirt-engine git repo is there. - will upload the other repositories soon.
This is terrific. Any pointers on setting up additional projects? I'd love to get ovirt-node uploaded.
You just need to ask... Timing wise - since once it is up there it is the master git and workflow is through it, so if the maintainers are not familiar with gerrit, may I suggest we do this the week after the workshop so will be easier to help with any issues? If the maintainers are already familiar with gerrit, we can go right ahead. In the meantime, please ask the maintainers to login to gerrit.ovirt.org with an OpenID account so I can setup the ovirt-node-maintainers group.
Thanks
Mike
below you can find the steps on how to get the code (yes, coming to you in wiki soon). a link to the wiki on how to build oVirt will be sent soon by Livnat.
It's exciting to see everyone coming together to build a community, and I'm looking forward to working together on oVirt.
Welcome everyone, Itamar
How to use: 1. registering as a user: - you can use any OpenID provider for now[1] - login page shows google and yahoo - any fedora FAS account can login as well via https://admin.fedoraproject.org/accounts/openid/id/<username>
2. set ssh keys in gerrit settings - on your local machine, create a set of ssh keys if you don't have one via 'ssh-keygen -t rsa' - update via gerrit settings the ssh public key to allow ssh to gerrit
3. define gerrit in ~/.ssh/config Host gerrit.ovirt.org HostName gerrit.ovirt.org Port 29418 User <username>
4. check ssh works correctly, verify and ack the host fingerprint: ssh gerrit.ovirt.org if you get this, it is fine: *** Welcome to Gerrit Code Review ****
5. cloning the repo git clone gerrit.ovirt.org:ovirt-engine this can be done without registering to gerrit using: git clone git://gerrit.ovirt.org/ovirt-engine
6. install the change-Id hook - you must do this before you commit anything: scp -p gerrit.ovirt.org:hooks/commit-msg .git/hooks/
7. do some work/commit/etc. wiki link on how to build/run ovirt will be sent by Livnat soon.
8. rebase: git fetch gerrit.ovirt.org:ovirt-engine master
9. push your patch for review: git push gerrit.ovirt.org:ovirt-engine HEAD:refs/for/master
10. track patch review process the review process is comprised of: - anyone can send a patch - anyone can code review and comment on the patch and +1/-1. This helps maintainers in reviewing the patches. - a maintainer can code review it with +2 it, which is required to commit (submit) it. - someone (anyone) needs to confirm they checked the patch works and flag it as verified +1 - a maintainer can submit (commit) the patch when it has: Code Review: +2 Verified: +1 - nacked (-1) patches should not be submitted - a submitted patch is merged to the git
TODOs: - emails to mailing list on patches/commits[2] - upload repos of more projects - have gerrit add acked-by/verified-by based on the gerrit reviewes? - mirror to github
[1] if anyone provides a reason to limit to specific OpenID providers that's an option as well. [2] basic emails until we merge the gerrit patches sending them inline - we are working on sending them to upstream gerrit. _______________________________________________ Board mailing list Board@ovirt.org http://lists.ovirt.org/mailman/listinfo/board