The problem is that the package which is currently in tested is an un-authorised package that is actually breaking all the projects and not just engine.
it has been transferred manually as I cannot see a passing ovirt-engine cq test for over a month and the package that is there is pointing at an un-merged change.

We should not touch CQ manually ever as doing that breaks it completely and makes it more difficult to find and fix any other issues and breaks all other projects as well.

I have re-merged the fix that you pointed to to see what is causing it to fail CQ and will update once it goes through cq and we can see what other issues we have.

Thanks,
Dafna



On Wed, Feb 12, 2020 at 1:02 PM Martin Perina <mperina@redhat.com> wrote:


On Wed, Feb 12, 2020 at 11:07 AM Dafna Ron <dron@redhat.com> wrote:
Then another possibility is that the package is now suppose to be coming from somewhere else and its not available?
where is it suppose to come from? from what I understood, it should be deployed by ansible, is that correct?
I can see an abandoned patch but cannot see a patch that was merged for ansible:

It seems patch: https://gerrit.ovirt.org/#/c/102959/ was abandoned for no activity - was anything else actually merged on ansible side?

Thanks,
Dafna


On Wed, Feb 12, 2020 at 9:47 AM Yedidyah Bar David <didi@redhat.com> wrote:
On Wed, Feb 12, 2020 at 11:39 AM Dafna Ron <dron@redhat.com> wrote:
>
> this is the current package in tested: ovirt-engine-0:4.2.0-0.0.master.20170712084142.git63b81ef.el7.centos.noarch and since all projects are now failing on this, it means the engine package in tested is a broken package.
> what I don't understand is how can CQ mark engine as failed since this patch: https://gerrit.ovirt.org/#/c/104391/ which is 4 weeks ago but I can see a new package in tested since 06-02-2020 with no passing cq test for ovirt-engine.
> If anyone is moving packages manually to tested they are breaking all projects by introducing broken packages.
>
> As the package in tested is now broken, we should start fixing the code on each failing issue.
> for now, the main thing that is failing is that we are looking for a package that no longer exists.
> Didi, is it possible its the typo Marcin was commenting on in this patch: https://gerrit.ovirt.org/#/c/106797/

I already addressed this,

https://gerrit.ovirt.org/106809 was a fix for that issue, if it still didn't pass the CQ, then let's pass the engine build this patch through CQ manually


>
> Thanks,
> Dafna
>
>
>
>
>
>
>
> On Tue, Feb 11, 2020 at 9:03 AM Yedidyah Bar David <didi@redhat.com> wrote:
>>
>> On Tue, Feb 11, 2020 at 10:22 AM Dusan Fodor <dfodor@redhat.com> wrote:
>> >
>> > Hello,
>> > master CQ is failing on initialize_engine due to missing ovirt-host-deploy dependency.
>> >
>> > [ INFO  ] Checking for an update for Setup...
>> > [ ERROR ] Yum Cannot queue package ovirt-host-deploy: Package ovirt-host-deploy cannot be found
>> >
>> >
>> > I was under the impression that engine-setup should not require it anymore, but it seems the related patch [1] doesn't work as intended. Perhaps Marcin's comment there explains why? Can you please check this?
>>
>> How can I know which engine build was used for [2]?
>>
>> Checking lago.log there, I see:
>>
>> Installed:
>>   net-snmp.x86_64 1:5.7.2-43.el7_7.3
>>   ntp.x86_64 0:4.2.6p5-29.el7.centos
>>   otopi-debug-plugins.noarch 0:1.9.0-1.el7
>>   ovirt-engine.noarch 0:4.4.0-0.0.master.20200206140618.gitff1f0b4.el7
>>   ovirt-engine-extension-aaa-ldap.noarch 0:1.3.11-0.0.master.gitb9a171f.el7
>>   ovirt-engine-extension-aaa-ldap-setup.noarch
>> 0:1.3.11-0.0.master.gitb9a171f.el7
>>   ovirt-log-collector.noarch 0:4.4.0-0.0.master.20191122133512.gitfc29382.el7
>>
>> ff1f0b4 is a hash of a not-yet-merged patch:
>>
>> https://gerrit.ovirt.org/106794
>>
>> It should be rebased.
>>
>> Also not sure how the change-queue-tester uses a not-merged-yet engine.
>>
>> (And also, [1] is not enough, Marcin Sobczyk later pushed a fix for
>> it, https://gerrit.ovirt.org/106809 ).

here ^^. Already merged as well.

>>
>> > Job example [2]
>> > Thanks
>> >
>> > [1] https://gerrit.ovirt.org/#/c/106797/
>> > [2] https://jenkins.ovirt.org/view/Change%20queue%20jobs/job/ovirt-master_change-queue-tester/19724/testReport/(root)/001_initialize_engine/initialize_engine/
>>
>>
>>
>> --
>> Didi
>> _______________________________________________
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-leave@ovirt.org
>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
>> List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/I5NOUPCLFXQDKDBHNIQC2XL56YZYLGOT/



--
Didi

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-leave@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/
List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZAXMQR773ODCQSDK7TK7QV62LRFGOYOV/


--
Martin Perina
Manager, Software Engineering
Red Hat Czech s.r.o.