Change in ovirt-engine[master]: core: Block Hotplug Nic in Certain Vm States (#826931)
Muli Salem has submitted this change and it was merged.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
......................................................................
core: Block Hotplug Nic in Certain Vm States (#826931)
https://bugzilla.redhat.com/826931
This patch adds a canDoAction that makes sure the
VM is in a valid state for attaching a network interface.
The patch also adds a check in AddVmInterfaceCommand,
to make sure Hotplug is supported by OS and according to flag
in vdc_options.
Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 46 insertions(+), 11 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server