Change in ovirt-engine[master]: userportal, webadmin: fixed tabindexes for login pages
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed tabindexes for login pages
......................................................................
userportal, webadmin: fixed tabindexes for login pages
Since PatternFly adoption, tabbing through fields on the login pages
was erratic. Fixed to be in the proper, predictable order.
As part of fixing this, changed UiCommonEditorVisitor to not set
tabindex on an editor if it's already set (i.e. don't override a
manually-set tabindex).
Change-Id: I434eb12b5efe003c0d1c139ad94d4d352668f403
Bug-Url: https://bugzilla.redhat.com/1154051
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/PatternflyUiCommandButton.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml
4 files changed, 22 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit http://gerrit.ovirt.org/34738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I434eb12b5efe003c0d1c139ad94d4d352668f403
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server