Allon Mureinik has submitted this change and it was merged.
Change subject: core: AuditLogDAOTest date format
......................................................................
core: AuditLogDAOTest date format
Since SimpleDateFormat is inherently not thread-safe and some runners
may run different tests in different thread, it's a potential bug to use
a static instance of it.
Additionally, this issue is picked up by recent version of FindBugs and
Coverity, generating noise.
Change-Id: I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/25116
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41384f1f061bcffbc08c2f0fda8633d2f42bd5a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server