Change in ovirt-engine[master]: core: Optimize equals/hashCode in ux classes
Martin Peřina has submitted this change and it was merged.
Change subject: core: Optimize equals/hashCode in ux classes
......................................................................
core: Optimize equals/hashCode in ux classes
1. Optimizes equals method to contain recommended functionality as
described in Effective Java 2nd edition
2. Optimizes objects comparison in equals method to use Objects.equals()
3. Optimizes hashCode method to use Objects.hash()/hashCode() methods
Change-Id: I4dedbb85e1ac8f171b180ececbd25adc572fb66b
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperation.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginData.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/ElementIdStatement.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplySearchStringEvent.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimerStateChangeEvent.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/MainModelSelectionChangeEvent.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ValidationResult.java
M
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingBackendModel.java
M
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingFrontendModel.java
M
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModelTest.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java
12 files changed, 105 insertions(+), 175 deletions(-)
Approvals:
Martin Peřina: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dedbb85e1ac8f171b180ececbd25adc572fb66b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>