Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fence agent duplicate ip
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fence agent duplicate ip
......................................................................
webadmin: Fence agent duplicate ip
- The code was allowing the user to enter a duplicate
management ip, compared to the existing fence agents.
This would allow one to create duplicate entries that
a lot of the code was not able to handle. This patch
now checks if the management ip address of a new fence
agent is already there.
- Also check the list of existing fence agents when loading
and will remove duplicate management ips from the list.
Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 47 insertions(+), 9 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org