Change in ovirt-engine[master]: core: change RemoveVmFromImportExportParamenters to get VM I...
Omer Frenkel has submitted this change and it was merged.
Change subject: core: change RemoveVmFromImportExportParamenters to get VM ID
......................................................................
core: change RemoveVmFromImportExportParamenters to get VM ID
RemoveVmFromImportExportCommand only needs the ID of the VM to work
with, yet RemoveVmFromImportExportParamenters received VM object. at the
REST API and at the UI we were creating VM object just as a wrapper of
the VM ID to pass to the parameters class. This patch changes the
parameter class to receive ID of VM instead of VM object.
This patch also contains minor refactoring in
RemoveVmFromImportExportParamenters class.
Change-Id: I0fff20548248d3c47087d2d004d285c429a1c081
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
4 files changed, 17 insertions(+), 28 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, but someone else must approve
Omer Frenkel: Verified; Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/16707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fff20548248d3c47087d2d004d285c429a1c081
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server