3:57 p.m.
From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Improve HE Management in Host Dialogs
......................................................................
webadmin: Improve HE Management in Host Dialogs
Currently, the hosted engine side tab is shown only in the New Host
popup and is shown regardless of whether the engine is a hosted
engine installation or not. The side tab displays three options in
radio button form: NONE, DEPLOY, and UNDEPLOY.
This patch makes the following changes to improve the overall UX of
this feature:
1. The hosted engine side tab is only displayed if the engine is a
host engine installation.
2. The side tab is shown in the Edit Host popup in addition to the
New Host popup.
3. In the New Host popup, only the NONE and DEPLOY options are
displayed.
4. In the Edit Host popup the options displayed are dependent on
whether the host is an HE node or not.
a. If the host is an HE node, the NONE and UNDEPLOY options are
displayed, unless the host is the last HE node in the system.
If it is the last HE node, the element is disabled and a
tooltip is added explaining that HE cannot be undeployed from
the last HE node.
b. If the host is not an HE node, the NONE and DEPLOY options are
displayed.
5. Changes the element from a radio button group to a dropdown list.
Feature page: http://www.ovirt.org/develop/release-management/features
/hosted-engine-improve-management-in-host-dialogs/
Depends on: https://gerrit.ovirt.org/#/c/68120/
Change-Id: Ia5b5012a820289700c4f491229325f4ea9b11630
Bug-Url: https://bugzilla.redhat.com/1369827
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostedEngineHostModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
9 files changed, 104 insertions(+), 27 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/66773
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b5012a820289700c4f491229325f4ea9b11630
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>