Change in ovirt-engine[master]: core: Fix permissions for profiles created for new domain
Roy Golan has submitted this change and it was merged.
Change subject: core: Fix permissions for profiles created for new domain
......................................................................
core: Fix permissions for profiles created for new domain
The AddDiskProfileCommand takes care of the permissions for newly
added disk profiles and gives the users in Everyone group the
DiskProfileUser role.
AddStorageDomain command added the created disk profile directly
to the DB without calling the command and so this role was not
assigned.
The fix was to call AddDiskProfileCommand directly from
AddStorageDomain and also from AddStorageDomainToPoolCommand which
creates a disk profile in case one doesn't exist for the storage domain.
Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459
Bug-Url: https://bugzilla.redhat.com/1209505
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java
4 files changed, 30 insertions(+), 25 deletions(-)
Approvals:
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Phillip Bailey: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, but someone else must approve
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/56573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>