Change in ovirt-engine[ovirt-engine-3.3]: userportal: Fix nasty issue in MenuPanelPopup
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Fix nasty issue in MenuPanelPopup
......................................................................
userportal: Fix nasty issue in MenuPanelPopup
When running UserPortal in web (compiled) mode, a very
nasty issue occurs in MenuPanelPopup constructor. This
issue occurs *only* in web mode and causes UserPortal
login screen to hang after successful authentication.
JS stacktrace points to MenuPanelPopup using UiBinder:
- UiBinder-generated code does SimplePanel.add(widget)
as per <g:SimplePanel> in MenuPanelPopup.ui.xml
- for some reason, 'widget' is an instance of
DecoratedPopupPanel, instead of expected PopupPanel
- JS TypeError occurs with following message:
DecoratedPopupPanel.decPanel field is not initialized
This patch fixes this issue by removing UiBinder usage
from MenuPanelPopup. This isn't a big deal, since
MenuPanelPopup uses UiBinder *only* to apply CSS styles,
its widgets are declared using @UiField(provided=true).
Change-Id: Ic3f9c3318234bb5315f950c0cba44e6eaa8cb24f
Bug-Url: https://bugzilla.redhat.com/992960
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/MenuPanelPopup.java
D
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/MenuPanelPopup.ui.xml
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/MenuPanelPopup.css
3 files changed, 52 insertions(+), 50 deletions(-)
Approvals:
Alexander Wels: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3f9c3318234bb5315f950c0cba44e6eaa8cb24f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org