4:20 a.m.
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Add infrastructure for Cluster Edit Checks
......................................................................
core: Add infrastructure for Cluster Edit Checks
Added infrastructure to encapsulate various checks and user-facing warnings
when edit of cluster may have harmful consequences.
With this new infrastructure new checks were added:
* when enabling /dev/random on cluster whether hosts support it
* when enabling /dev/hwrng on cluster whether hosts support it
* when increasing cluster level, whether host support new machine types
And existing check refactored into new infrastructure:
* when decreasing cluster CPU level and VM have higher CPU
level override than the new value
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1202349
Change-Id: I3ead66a953380210986b26a54c239fa591335bac
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceClusterEditChecker.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterEditChecker.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EmulatedMachineClusterEditChecker.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterUnsupportedVmsCpusQuery.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HwrngDeviceClusterEditChecker.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RandomDeviceClusterEditChecker.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UnsupportedVmCpuClusterEditChecker.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ClusterEditWarnings.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ClusterEditParameters.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterUnsupportedVmsCpusParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterWarningsModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterWarningsPopupPresenterWidget.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterWarningsPopupView.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterWarningsPopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
28 files changed, 713 insertions(+), 147 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44766
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ead66a953380210986b26a54c239fa591335bac
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org