Change in ovirt-engine[master]: packaging: engine-service: major cleanup
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-service: major cleanup
......................................................................
packaging: engine-service: major cleanup
Last patch in series of engine-service, after all core issues merged
into existing implementation, this introduce python only rework and
cleanups.
1. Removal global variable.
2. Previous patch already use python subprocess instead of direct exec.
3. Use python logging instead of direct syslog calls.
4. Add debug log.
5. Add debug parameter.
6. Add gettext support.
7. Modular functional.
8. Remove one time used variables.
9. Remove replication of configuration variable into local variables.
10. Remove dead code.
11. pyflakes free
12. pep8 complaint.
Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/engine-service.py.in
M packaging/fedora/engine-service.systemd.in
M packaging/fedora/engine-service.sysv.in
3 files changed, 887 insertions(+), 601 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>