Change in ovirt-engine[master]: frontend: Improve DontPrune aspect code
From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: frontend: Improve DontPrune aspect code
......................................................................
frontend: Improve DontPrune aspect code
- added some comments to explain the details
- use Java 8 stream API to reduce code complexity
Note: in aop.xml file, we're configuring AOP weaver to apply
aspects not only to the code we want to advise (3rd party GWT
class ControlFlowAnalyzer) but also to the aspect Java class
itself (DontPrune). Without this, the build fails, so I guess
this is needed simply to ensure the aspect's Java class gets
properly loaded by AspectJ AOP weaver.
Change-Id: I14e84d3193cfcc49582d3cf85e5140be8e364eb0
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/DontPrune.java
M frontend/webadmin/modules/gwt-aop/src/main/resources/META-INF/aop.xml
2 files changed, 31 insertions(+), 29 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/76438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14e84d3193cfcc49582d3cf85e5140be8e364eb0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>